linux-kernel - Re: User switchable HW mappings & cie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061009120055.GD26824@wotan.suse.de>
Date:	Mon, 9 Oct 2006 14:00:55 +0200
From:	Nick Piggin <npiggin@...e.de>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Thomas Hellström <thomas@...gstengraphics.com>,
	linux-mm@...ck.org,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Hugh Dickins <hugh@...itas.com>, Arnd Bergmann <arnd@...db.de>,
	Linus Torvalds <torvalds@...l.org>
Subject: Re: User switchable HW mappings & cie

On Mon, Oct 09, 2006 at 09:51:01PM +1000, Benjamin Herrenschmidt wrote:
> 
> > I'm very much for this approach, possibly with the extension that we 
> > could have a multiple-page version as well, as populating the whole vma 
> > sometimes may be cheaper than populating each pte with a fault. That 
> > would basically be an io_remap_pfn_range() which is safe when the 
> > mmap_sem is taken in read mode (from do_no_page).
> > 
> > One problem that occurs is that the rule for ptes with non-backing 
> > struct pages
> > Which I think was introduced in 2.6.16:
> > 
> >     pfn_of_page == vma->vm_pgoff + ((addr - vma->vm_start) >> PAGE_SHIFT)
> > 
> > cannot be honored, at least not with the DRM memory manager, since the 
> > graphics object will be associated with a vma and not the underlying 
> > physical address. User space will have vma->vm_pgoff as a handle to the 
> > object, which may move around in graphics memory.
> 
> That's a problem with VM_PFNMAP set indeed. get_user_pages() is a
> non-issue with VM_IO set too but I'm not sure about other code path that
> might try to hit here... though I think we don't hit that if MAP_SHARED,
> Nick ?

No, if you are MAP_SHARED then you shouldn't need to worry about that
indeed. For new code, I don't think it should be painful to avoid writing
to MAP_PRIVATE mappings.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/