linux-kernel - Re: [patch 1/2] libata:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 9 Oct 2006 08:10:37 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Stefan Seyfried <seife@...e.de>
Cc:	Kristen Carlson Accardi <kristen.c.accardi@...el.com>,
	linux-kernel@...r.kernel.org, jgarzik@...ox.com,
	linux-ide@...r.kernel.org
Subject: Re: [patch 1/2] libata: _GTF support

On Mon, 9 Oct 2006 13:41:50 +0200 Stefan Seyfried wrote:

> On Wed, Sep 27, 2006 at 03:36:27PM -0700, Kristen Carlson Accardi wrote:
> > _GTF is an acpi method that is used to reinitialize the drive.  It returns
> > a task file containing ata commands that are sent back to the drive to restore
> > it to boot up defaults.
> > 
> > Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@...el.com>
> > 
> > ---
> >  Documentation/kernel-parameters.txt |    5 
>  
> > --- 2.6-mm.orig/Documentation/kernel-parameters.txt
> > +++ 2.6-mm/Documentation/kernel-parameters.txt
> > @@ -48,6 +48,7 @@ parameter is applicable:
> >  	ISAPNP	ISA PnP code is enabled.
> >  	ISDN	Appropriate ISDN support is enabled.
> >  	JOY	Appropriate joystick support is enabled.
> > +	LIBATA  Libata driver is enabled
> >  	LP	Printer support is enabled.
> >  	LOOP	Loopback device support is enabled.
> >  	M68k	M68k architecture is enabled.
> > @@ -1013,6 +1014,10 @@ and is between 256 and 4096 characters. 
> >  			emulation library even if a 387 maths coprocessor
> >  			is present.
> >  
> > +	noacpi		[LIBATA] Disables use of ACPI in libata suspend/resume
> > +			when set.
> > +			Format: <int>
> 
> this will confuse users that already think they can disable ACPI with "noacpi"
> (instead of "acpi=off") and that already fight with "noapic". I have seen too
> many confusions of this kind in bugreports.
> 
> Couldn't it be made "libata=noacpi" like we have "pci=noacpi" already?

It only applies to the libata module, so it could be more fully
documented as "libata.noacpi=1" to disable ACPI for libata.
We don't usually do that in Documentation/kernel-parameters.txt,
but there are a few cases/examples of doing so.

Of course, that's for libata built-in the kernel image.  If libata
is a loadable module, it's just
	modprobe libata noacpi=1
or set it in /etc/modprobe.conf.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/