linux-kernel - [PATCH 1/3] drivers/scsi/ibmmca.c: Replacing yield() with a better alternative

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1160571241.19143.318.camel@amol.verismonetworks.com>
Date:	Wed, 11 Oct 2006 18:24:01 +0530
From:	Amol Lad <amol@...ismonetworks.com>
To:	linux kernel <linux-kernel@...r.kernel.org>
Cc:	James.Bottomley@...eleye.com,
	kernel Janitors <kernel-janitors@...ts.osdl.org>
Subject: [PATCH 1/3] drivers/scsi/ibmmca.c: Replacing yield() with a better
	alternative

In 2.6, the semantics of calling yield() changed from "sleep for a
bit" to "I really don't want to run for a while".  This matches POSIX
better, but there's a lot of drivers still using yield() when they mean
cond_resched(), schedule() or even schedule_timeout().

For this driver cond_resched() seems to be a better
alternative

Tested compile only

Signed-off-by: Amol Lad <amol@...ismonetworks.com>
---
diff -uprN -X linux-2.6.19-rc1-orig/Documentation/dontdiff linux-2.6.19-rc1-orig/drivers/scsi/ibmmca.c linux-2.6.19-rc1/drivers/scsi/ibmmca.c
--- linux-2.6.19-rc1-orig/drivers/scsi/ibmmca.c	2006-09-21 10:15:39.000000000 +0530
+++ linux-2.6.19-rc1/drivers/scsi/ibmmca.c	2006-10-11 17:57:02.000000000 +0530
@@ -2268,7 +2268,7 @@ static int __ibmmca_host_reset(Scsi_Cmnd
 		if (!(inb(IM_STAT_REG(host_index)) & IM_BUSY))
 			break;
 		spin_unlock_irq(shpnt->host_lock);
-		yield();
+		cond_resched();
 		spin_lock_irq(shpnt->host_lock);
 	}
 	/*write registers and enable system interrupts */


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/