linux-kernel - misused local_irq_disable() in analog.c?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6fcc0a0610111208s4dbb7c98xbdd3ceb13fba1503@mail.gmail.com>
Date:	Wed, 11 Oct 2006 23:08:52 +0400
From:	"Alexey Dobriyan" <adobriyan@...il.com>
To:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
Cc:	linux-joystick@...ey.karlin.mff.cuni.cz,
	linux-kernel@...r.kernel.org
Subject: misused local_irq_disable() in analog.c?

Dmitry, take a look at analog_cooked_read():

do-while loop there contains local_irq_disable()/local_irq_restore(flags);
which aren't complement.

Should it be

    local_irq_save(flags);
    this = gameport_read(gameport) & port->mask;
    GET_TIME(now);
    local_irq_restore(flags);

?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/