linux-kernel - Re: misused local_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d120d5000610111317k4e849707rc358fdd4ad5dae5b@mail.gmail.com>
Date:	Wed, 11 Oct 2006 16:17:33 -0400
From:	"Dmitry Torokhov" <dtor@...ightbb.com>
To:	"Alexey Dobriyan" <adobriyan@...il.com>
Cc:	linux-joystick@...ey.karlin.mff.cuni.cz,
	linux-kernel@...r.kernel.org
Subject: Re: misused local_irq_disable() in analog.c?

On 10/11/06, Alexey Dobriyan <adobriyan@...il.com> wrote:
> Dmitry, take a look at analog_cooked_read():
>
> do-while loop there contains local_irq_disable()/local_irq_restore(flags);
> which aren't complement.
>
> Should it be
>
>    local_irq_save(flags);
>    this = gameport_read(gameport) & port->mask;
>    GET_TIME(now);
>    local_irq_restore(flags);
>
> ?

Yep, I think so. Patch?

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/