linux-kernel - Re: [PATCH] SCSI/qla2xxx: handle sysfs errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <452E7966.7030206@garzik.org>
Date:	Thu, 12 Oct 2006 13:20:38 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Andrew Vasquez <andrew.vasquez@...gic.com>
CC:	linux-scsi@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] SCSI/qla2xxx: handle sysfs errors

Andrew Vasquez wrote:
> NACK, please don't do this.  SYSFS entries, albiet important, aren't
> necessarilly critical to a functioning driver.  I'd rather the driver
> not error out.

As discussed before, the only errors thrown are either ENOMEM or EFAULT, 
both of which are quite serious.


> Here's what I had stewing to address the must_check directives and
> qla2xxx:

If you're gonna change it that much, might as well use attribute groups.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/