linux-kernel - Re: [PATCH,RFC] Add __GFP_ZERO to GFP_LEVEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061013134635.a983e4d7.akpm@osdl.org>
Date:	Fri, 13 Oct 2006 13:46:35 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Jonathan Corbet <corbet@....net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH,RFC] Add __GFP_ZERO to GFP_LEVEL_MASK

On Fri, 13 Oct 2006 14:25:16 -0600
Jonathan Corbet <corbet@....net> wrote:

> There is a very helpful comment in <linux/gfp.h>:
> 
>   /* if you forget to add the bitmask here kernel will crash, period */
> 
> Well, my kernel has been crashing (period) at the BUG() in cache_grow();
> the offending flag is __GFP_ZERO.  I think it needs to be in
> GFP_LEVEL_MASK.  Anybody know a good reason why it's not there now?
> 

It would be a bit odd to pass __GFP_ZERO into the slab allocator.  Slab
doesn't need that hint: it has its own ways of initialising the memory.

What is the callsite?

Thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/