linux-kernel - Re: [PATCH] drivers/char/riscom8.c: save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Oct 2006 15:20:02 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Amol Lad <amol@...ismonetworks.com>
Cc:	linux kernel <linux-kernel@...r.kernel.org>,
	kernel Janitors <kernel-janitors@...ts.osdl.org>
Subject: Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti()
	removal

Ar Gwe, 2006-10-13 am 17:10 +0530, ysgrifennodd Amol Lad:
> Removed save_flags()/cli()/sti() and used (light weight) spin locks
> 

Three things I see that look problematic

1. The irq locking isn't doing anything as the IRQ handler itself is not
taking the lock
2. If the irq handler itself dumbly locks to fix this then we get
tty_flip_buffer_push() re-entering the other code paths and deadlocking
if low latency is enabled
3. Some of the use of local_save/spin_lock_irq seems over-clever and
unneeded

Fixable but how about we just delete the file since it has been broken
for ages and nobody can be using it ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/