lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Oct 2006 01:20:01 +0100 From: Alan Cox <alan@...rguk.ukuu.org.uk> To: Jiri Slaby <jirislaby@...il.com> Cc: Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org, R.E.Wolff@...Wizard.nl, Amit Gud <gud@....net>, Greg Kroah-Hartman <gregkh@...e.de> Subject: Re: [PATCH 1/1] Char: correct pci_get_device changes Ar Sul, 2006-10-15 am 01:36 +0200, ysgrifennodd Jiri Slaby: > correct pci_get_device changes > > Commits 881a8c120acf7ec09c90289e2996b7c70f51e996 and > efe1ec27837d6639eae82e1f5876910ba6433c3f are totally wrong and No I disagree, they are totally right. They stop crashes walking the list during a hotplug of another card. If you hotplug the moxa or rio card you are screwed. Your patches solve a different problem to the ones the pci_dev_get changes solve. Your changes also minimally handle the hotplug of the moxa or rio card which I guess could theoretically happen in some weird system and are a definite improvement. > It affects moxa and rio char drivers. (All this stuff deserves to be > converted to pci_probing, though.) Agreed, or dropped Acked-by: Alan Cox <alan@...hat.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists