linux-kernel - Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0610151433170.28406@yvahk01.tjqt.qr>
Date:	Sun, 15 Oct 2006 14:36:08 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Josef Sipek <jsipek@....cs.sunysb.edu>
cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	torvalds@...l.org, hch@...radead.org, viro@....linux.org.uk,
	linux-fsdevel@...r.kernel.org, penberg@...helsinki.fi,
	ezk@...sunysb.edu, mhalcrow@...ibm.com
Subject: Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*


>> Many of these functions are too large to be inlined.  Suggest they be
>> placed in fs/fs-stack.c (or whatever we call it).

fs/stack.c would probably be enough -- fs/fs-stack.c is like
include/linux/reiserfs_fs.h

>Ack. As a rule of thumb, for functions like these (laundry list of
>assignments), what's a good threshold?

3 or 4 I guess. Might want to take a look at other static-inline functions.


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/