linux-kernel - Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061013133722.d4f33ecb.akpm@osdl.org>
Date:	Fri, 13 Oct 2006 13:37:22 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Josef Sipek <jsipek@....cs.sunysb.edu>
Cc:	linux-kernel@...r.kernel.org, torvalds@...l.org, hch@...radead.org,
	viro@....linux.org.uk, linux-fsdevel@...r.kernel.org,
	penberg@...helsinki.fi, ezk@...sunysb.edu, mhalcrow@...ibm.com
Subject: Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*

On Fri, 13 Oct 2006 16:07:05 -0400
Josef Sipek <jsipek@....cs.sunysb.edu> wrote:

> > > +static inline void __stackfs_copy_attr_all(struct inode *dest,
> > > +					   const struct inode *src,
> > > +					   int (*get_nlinks)(struct inode *))
> > > +{
> > > +	if (!get_nlinks)
> > > +		dest->i_nlink = src->i_nlink;
> > > +	else
> > > +		dest->i_nlink = get_nlinks(dest);
> > 
> > I cannot find a get_nlinks() in 2.6.19-rc2?
>  
> It is the last argument to the function. Perhaps the function name is
> deceiving.

doh.

That's why us old farts like to see

	dest->i_nlink = (*get_nlinks)(dest);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/