linux-kernel - [patch] slab: Fix a cpu hotplug race condition while tuning slab cpu caches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061016085439.GA6651@localhost.localdomain>
Date:	Mon, 16 Oct 2006 01:54:39 -0700
From:	Ravikiran G Thirumalai <kiran@...lex86.org>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org,
	Christoph Lameter <clameter@...r.sgi.com>,
	Alok Kataria <alok.kataria@...softinc.com>,
	"Shai Fultheim (Shai@...lex86.org)" <shai@...lex86.org>,
	"Benzi Galili (Benzi@...leMP.com)" <benzi@...lemp.com>
Subject: [patch] slab: Fix a cpu hotplug race condition while tuning slab cpu caches

Fix a cpu hotplug race condition while tuning slab cpu caches.

CPU online (cpu_up) and tuning slab caches (do_tune_cpucache)
can race and can lead to a situation where we do not have an 
arraycache allocated for a newly onlined cpu.

The race can be explained as follows:

cpu_online_map 00000111
cpu_up(3)	
  cpuup_callback CPU_UP_PREPARE:
    mutex_lock(&cache_chain_mutex);
    ...						
    allocate_array_cache for cpu 3
    ...
    mutex_unlock(&cache_chain_mutex);
    ...						slabinfo_write
    ...						mutex_lock(&cache_chain_mutex);
    ...						  do_tune_cpucache
    ...						    allocate new arraycache for cpu0,1,2, NULL rest
    ...						    ...
  mutex_lock(&cpu_bitmask_lock);		    ...
  cpu_online_map 00001111
  mutex_unlock(&cpu_bitmask_lock);		    ...
						  on_each_cpu swap the new array_cache with old
						  ^^^^
						  CPU 3 gets assigned with a NULL array cache

Hence, when do_ccupdate_local is run on CPU 3, CPU 3 gets a NULL array_cache,
and caused badness thereon.

So don't allow cpus to come and go while in do_tune_cpucache.
The other code path of do_tune_cpucache through kmem_cache_create
is already protected through lock_cpu_hotplug.

Signed-off-by: Alok N Kataria <alokk@...softinc.com>
Signed-off-by: Ravikiran Thirumalai <kiran@...lex86.org>
Signed-off-by: Shai Fultheim <shai@...lex86.org>

Index: linux-2.6.19-rc1slab/mm/slab.c
===================================================================
--- linux-2.6.19-rc1slab.orig/mm/slab.c	2006-10-13 12:35:02.578841000 -0700
+++ linux-2.6.19-rc1slab/mm/slab.c	2006-10-13 12:35:46.848841000 -0700
@@ -4072,6 +4072,7 @@ ssize_t slabinfo_write(struct file *file
 		return -EINVAL;
 
 	/* Find the cache in the chain of caches. */
+	lock_cpu_hotplug();
 	mutex_lock(&cache_chain_mutex);
 	res = -EINVAL;
 	list_for_each_entry(cachep, &cache_chain, next) {
@@ -4087,6 +4088,7 @@ ssize_t slabinfo_write(struct file *file
 		}
 	}
 	mutex_unlock(&cache_chain_mutex);
+	unlock_cpu_hotplug();
 	if (res >= 0)
 		res = count;
 	return res;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/