linux-kernel - Re: [patch] cpu topology: consider sysfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061016105547.3b184e78@gondolin.boeblingen.de.ibm.com>
Date:	Mon, 16 Oct 2006 10:55:47 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Andrew Morton <akpm@...l.org>, Jeff Garzik <jgarzik@...ox.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] cpu topology: consider sysfs_create_group return value

On Mon, 16 Oct 2006 09:31:26 +0200,
Heiko Carstens <heiko.carstens@...ibm.com> wrote:

> From: Heiko Carstens <heiko.carstens@...ibm.com>
> 
> [patch] cpu topology: consider sysfs_create_group return value.
> 
> Take return value of sysfs_create_group() into account. That function got
> called in case of CPU_ONLINE notification. Since callbacks are not allowed
> to fail on CPU_ONLINE notification do the sysfs group creation on
> CPU_UP_PREPARE notification.
> Also remember if creation succeeded in a bitmask. So it's possible to know
> wether it's legal to call sysfs_remove_group or not.
> 
> In addition some other minor stuff:
> 
> - since CPU_UP_PREPARE might fail add CPU_UP_CANCELED handling as well.
> - use hotcpu_notifier instead of register_hotcpu_notifier.
> - #ifdef code that isn't needed in the !CONFIG_HOTPLUG_CPU case.
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
> ---
> 
>  drivers/base/topology.c |   56 +++++++++++++++++++++++++++---------------------
>  1 file changed, 32 insertions(+), 24 deletions(-)

Looks good.

Reviewed-by: Cornelia Huck <cornelia.huck@...ibm.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/