linux-kernel - Re: [PATCH 4/6] net: use bitrev8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45389CE4.7050406@tls.msk.ru>
Date:	Fri, 20 Oct 2006 13:54:44 +0400
From:	Michael Tokarev <mjt@....msk.ru>
To:	Andrew Morton <akpm@...l.org>
CC:	Akinobu Mita <akinobu.mita@...il.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Jeff Garzik <jgarzik@...ox.com>,
	Paul Mackerras <paulus@...ba.org>,
	Mirko Lindner <mlindner@...konnect.de>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: [PATCH 4/6] net: use bitrev8

Andrew Morton wrote:
> On Thu, 19 Oct 2006 01:46:47 +0900
> Akinobu Mita <akinobu.mita@...il.com> wrote:
> 
>> Use bitrev8 for bmac, mace, macmace, macsonic, and skfp drivers.
>>
[]
>> ===================================================================
>> --- work-fault-inject.orig/drivers/net/Kconfig
>> +++ work-fault-inject/drivers/net/Kconfig
>> @@ -2500,6 +2500,7 @@ config DEFXX
>>  config SKFP
>>  	tristate "SysKonnect FDDI PCI support"
>>  	depends on FDDI && PCI
>> +	select BITREVERSE
>>  	---help---
>>  	  Say Y here if you have a SysKonnect FDDI PCI adapter.
>>  	  The following adapters are supported by this driver:
> 
[]
> But select is problematic and I do wonder whether it'd be simpler to just
> link the thing into vmlinux.

Why it's problematic?  Maintenance costs of various missing selects?
I don't want extra stuff in kernel (vmlinux) if it's not used.

/mjt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/