linux-kernel - Re: [PATCH 4/6] net: use bitrev8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061020025045.GB6344@localhost>
Date:	Fri, 20 Oct 2006 11:50:45 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Jeff Garzik <jgarzik@...ox.com>,
	Paul Mackerras <paulus@...ba.org>,
	Mirko Lindner <mlindner@...konnect.de>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: [PATCH 4/6] net: use bitrev8

On Thu, Oct 19, 2006 at 01:39:51PM -0700, Andrew Morton wrote:

> A bunch of drivers.
> 
> > ===================================================================
> > --- work-fault-inject.orig/drivers/net/Kconfig
> > +++ work-fault-inject/drivers/net/Kconfig
> > @@ -2500,6 +2500,7 @@ config DEFXX
> >  config SKFP
> >  	tristate "SysKonnect FDDI PCI support"
> >  	depends on FDDI && PCI
> > +	select BITREVERSE
> >  	---help---
> >  	  Say Y here if you have a SysKonnect FDDI PCI adapter.
> >  	  The following adapters are supported by this driver:
> 
> But only one of them selects the library.

Other drivers already select CRC32 and CRC32 selects BITREVERSE.

> But select is problematic and I do wonder whether it'd be simpler to just
> link the thing into vmlinux.

OK. I'll try.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/