linux-kernel - Re: [PATCH] (update) more helpful WARN_ON and BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1161363746.5230.55.camel@lappy>
Date:	Fri, 20 Oct 2006 19:02:26 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Eric Sandeen <sandeen@...deen.net>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] (update) more helpful WARN_ON and BUG_ON messages

On Fri, 2006-10-20 at 11:54 -0500, Eric Sandeen wrote:
> Eric Sandeen wrote:
> 
> > After a few bugs I encountered in FC6 in buffer.c, with output like:
> >
> > Kernel BUG at fs/buffer.c: 2791
> >
> > where buffer.c contains:
> >
> > ...
> >         BUG_ON(!buffer_locked(bh));
> >         BUG_ON(!buffer_mapped(bh));
> >         BUG_ON(!bh->b_end_io);
> > ...
> >
> > around line 2790, it's awfully tedious to go get the exact failing kernel tree
> > just to see -which- BUG_ON was encountered.
> >
> > Printing out the failing condition as a string would make this more helpful IMHO.
> >
> > This is mostly just compile-tested... comments?
> Whoops, missed WARN_ON_ONCE... thanks Peter.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

I like this, as you pointed out, its not always obvious which condition
is the offending one, this makes it more clear.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/