linux-kernel - Re: [NFS] [PATCH 07/11] NFS: fix minor bug in new NFS symlink code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76bd70e30610192157q3c2252b4s62e7bf985b4b487d@mail.gmail.com>
Date:	Fri, 20 Oct 2006 00:57:49 -0400
From:	"Chuck Lever" <chucklever@...il.com>
To:	"Andrew Morton" <akpm@...l.org>
Cc:	"Trond Myklebust" <Trond.Myklebust@...app.com>,
	"Linus Torvalds" <torvalds@...l.org>, nfs@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [NFS] [PATCH 07/11] NFS: fix minor bug in new NFS symlink code

On 10/20/06, Andrew Morton <akpm@...l.org> wrote:
> On Thu, 19 Oct 2006 13:04:32 -0400
> Trond Myklebust <Trond.Myklebust@...app.com> wrote:
>
> > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> > index 58d4405..c86a1ea 100644
> > --- a/fs/nfs/dir.c
> > +++ b/fs/nfs/dir.c
> > @@ -1519,8 +1519,8 @@ static int nfs_symlink(struct inode *dir
> >       pagevec_init(&lru_pvec, 0);
> >       if (!add_to_page_cache(page, dentry->d_inode->i_mapping, 0,
> >                                                       GFP_KERNEL)) {
> > -             if (!pagevec_add(&lru_pvec, page))
> > -                     __pagevec_lru_add(&lru_pvec);
> > +             pagevec_add(&lru_pvec, page);
> > +             pagevec_lru_add(&lru_pvec);
> >               SetPageUptodate(page);
> >               unlock_page(page);
> >       } else
>
> One could export add_to_page_cache_lru() to modules..

I assumed there was probably a good reason that this had not already been done.

-- 
"We who cut mere stones must always be envisioning cathedrals"
   -- Quarry worker's creed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/