linux-kernel - Re: 2.6.19-rc2-mm2 : empty files on vfat file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <873b9htne9.fsf@duaron.myhome.or.jp>
Date:	Sun, 22 Oct 2006 05:38:38 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Andrew Morton <akpm@...l.org>
Cc:	Damien Wyart <damien.wyart@...e.fr>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Nick Piggin <npiggin@...e.de>
Subject: Re: 2.6.19-rc2-mm2 : empty files on vfat file system

Andrew Morton <akpm@...l.org> writes:

> On Sat, 21 Oct 2006 19:38:49 +0200
> Damien Wyart <damien.wyart@...e.fr> wrote:
>
>> > --- a/fs/fat/inode.c~fs-prepare_write-fixes
>> > +++ a/fs/fat/inode.c
>> > @@ -150,7 +150,11 @@ static int fat_commit_write(struct file 
>> >  			    unsigned from, unsigned to)
>> >  {
>> >  	struct inode *inode = page->mapping->host;
>> > -	int err = generic_commit_write(file, page, from, to);
>> > +	int err;
>> > +	if (to - from > 0)
>> > +		return 0;
>> > +
>
> That should have been
>
> 	if (to - from == 0)
> 		return 0;

As I said in this thread, generic_cont_expand() uses "to == from".
Should we fix generic_cont_expand() instead? I don't know the
background of this patch.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/