linux-kernel - Re: 2.6.19-rc2-mm2 : empty files on vfat file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061022013427.GA17694@wotan.suse.de>
Date:	Sun, 22 Oct 2006 03:34:27 +0200
From:	Nick Piggin <npiggin@...e.de>
To:	Andrew Morton <akpm@...l.org>
Cc:	Damien Wyart <damien.wyart@...e.fr>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.19-rc2-mm2 : empty files on vfat file system

On Sat, Oct 21, 2006 at 01:24:31PM -0700, Andrew Morton wrote:
> On Sat, 21 Oct 2006 13:19:32 -0700
> Andrew Morton <akpm@...l.org> wrote:
> 
> > On Sat, 21 Oct 2006 19:38:49 +0200
> > Damien Wyart <damien.wyart@...e.fr> wrote:
> > 
> > > > --- a/fs/fat/inode.c~fs-prepare_write-fixes
> > > > +++ a/fs/fat/inode.c
> > > > @@ -150,7 +150,11 @@ static int fat_commit_write(struct file 
> > > >  			    unsigned from, unsigned to)
> > > >  {
> > > >  	struct inode *inode = page->mapping->host;
> > > > -	int err = generic_commit_write(file, page, from, to);
> > > > +	int err;
> > > > +	if (to - from > 0)
> > > > +		return 0;
> > > > +
> > 
> > That should have been
> > 
> > 	if (to - from == 0)
> > 		return 0;
> 
> otoh, it's still wrong that we're not updating i_size.  We happen to know
> that the caller will retry without dropping i_mutex, but it's a bit
> incestuous.

It can possibly fail for example if the source buffer gets unmapped.
However in the length == 0 case, that signals a failure to write anything
so we needn't update i_size, I think?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/