linux-kernel - Re: [PATCH 2.6.19-rc1 full] drivers: add LCD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Oct 2006 18:21:32 +0200
From:	"Miguel Ojeda" <maxextreme@...il.com>
To:	Franck <vagabon.xyz@...il.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.19-rc1 full] drivers: add LCD support

On 10/23/06, Franck Bui-Huu <vagabon.xyz@...il.com> wrote:
>
> [ note I'm not familiar with lcds...just try to understand what you've
>   done ]
>
> What I was worry about is that you actually wrote a frame buffer
> driver, which are normally located in drivers/video, and put it in a
> new directory drivers/auxdisplay. So now we have two places for frame
> buffer drivers. It looks like, now some frame buffer drivers in
> drivers/video should be moved in drivers/auxdisplay, shouldn't it ?
>
> Maybe just a stupid idea but why not restructuring the thing like:
>
>                 drivers
>                 |-- display
>                 |      |-- video
>                 |      |-- aux
>                 |      |-- fbmem.c
>                 |      |-- ...
>
>

Yes, I got your idea in your first message, and well, that was
discussed (however, not being a fbdev), and the people thought that
putting them together will, maybe, cause confusion; so having them out
from drivers/video should be better. Your idea, which merge them into
a "drivers/display" could be a good one, but I don't think people will
like to change such critical tree right now. Also, I'm not the one who
maintain such tree, so my opinion won't make changes about that ;)

>
> Another point: does the ks0108 controller is only used with the 'cfag'
> display ? If not, suppose I'm using the same controller with another
> lcd different from 'cfga'...Am I supposed to reuse your code in
> cfag12864b.c ?
>

No. You are supposed to _use_ the ks0108's exported functions: I split
the code into the ks0108 and the cfag12864b because I thought it was
the logical way, as the cfag12864b LCD just send the data through two
different ks0108 controllers. The same way, you can use the ks0108's
exported functions to create another whateverlcd.c which has one or
more ks0108 controllers.

>
> BTW, did you try to mmap your fbdev ? Does it work ?
>

Why it shouldn't? It doesn't work for you? AFAIK, it is a usual fbdev,
and you can map any fbdev as they are simple character file devices.

>
> Thanks
>                 Franck
>

Thanks
           Miguel Ojeda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/