linux-kernel - Re: [PATCH 8/13] KVM: vcpu execution loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <453D27F8.8020509@qumranet.com>
Date:	Mon, 23 Oct 2006 22:37:12 +0200
From:	Avi Kivity <avi@...ranet.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/13] KVM: vcpu execution loop

Arnd Bergmann wrote:
> On Monday 23 October 2006 22:16, Avi Kivity wrote:
>   
>>> This looks like you should simply put it into a .S file.
>>>
>>>  
>>>       
>> Then I lose all the offsetof constants down the line.  Sure, I could do
>> the asm-offsets dance but it seems to me like needless obfuscation.
>>     
>
> Ok, I see.
>
> How if you pass &vcpu->regs and &vcpu->cr2 to the functions instead of 
> kvm_vcpu?
>
>   

I could do that, but I feel that's more brittle.  I might need more (or 
other) fields later on.  It will also cost me more  pushes on the stack 
(no real performance or space impact, just C64-era frugality).


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/