[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <69304d110610231402k7913df63l7e493f95b5d92911@mail.gmail.com>
Date: Mon, 23 Oct 2006 23:02:54 +0200
From: "Antonio Vargas" <windenntw@...il.com>
To: "Avi Kivity" <avi@...ranet.com>, "Arnd Bergmann" <arnd@...db.de>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/13] KVM: vcpu execution loop
On 10/23/06, Avi Kivity <avi@...ranet.com> wrote:
> Arnd Bergmann wrote:
> > On Monday 23 October 2006 22:16, Avi Kivity wrote:
> >
> >>> This looks like you should simply put it into a .S file.
> >>>
> >>>
> >>>
> >> Then I lose all the offsetof constants down the line. Sure, I could do
> >> the asm-offsets dance but it seems to me like needless obfuscation.
> >>
> >
> > Ok, I see.
> >
> > How if you pass &vcpu->regs and &vcpu->cr2 to the functions instead of
> > kvm_vcpu?
> >
> >
>
> I could do that, but I feel that's more brittle. I might need more (or
> other) fields later on. It will also cost me more pushes on the stack
> (no real performance or space impact, just C64-era frugality).
maybe thats the mindsent needed to make these virtual cpu patches
without eating away all the cpu power with more than needed
abstractions ;)
--
Greetz, Antonio Vargas aka winden of network
http://network.amigascne.org/
windNOenSPAMntw@...il.com
thesameasabove@...gascne.org
Every day, every year
you have to work
you have to study
you have to scene.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists