linux-kernel - Re: [PATCH 2/3] spufs: fix another off-by-one bug in mbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200610242158.33069.arnd@arndb.de>
Date:	Tue, 24 Oct 2006 21:58:32 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	will_schmidt@...t.ibm.com
Cc:	Pekka Enberg <penberg@...helsinki.fi>, linuxppc-dev@...abs.org,
	Paul Mackerras <paulus@...ba.org>, cbe-oss-dev@...abs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] spufs: fix another off-by-one bug in mbox_read

On Tuesday 24 October 2006 21:53, Will Schmidt wrote:
> Hey Arnd,
>    just curiosity..   What was the behavior before this patch?   just
> leaving a few (0 - 3) characters behind?

It transfers more bytes than requested on a read. If you asked for
four bytes, you got eight.

Note: one nasty property of this file in spufs is that you can only
read multiples of four bytes in the first place, there is no way to
atomically put back a few bytes into the hardware register, so reading
less than four bytes returns -EINVAL. Asking for more than four
should return the largest possible multiple of four.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/