linux-kernel - Re: [PATCH] x86_64 irq: reuse vector for __assign_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440610260204t4620d25t2d2e40895203b17@mail.gmail.com>
Date:	Thu, 26 Oct 2006 02:04:57 -0700
From:	"Yinghai Lu" <yinghai.lu@....com>
To:	"Andi Kleen" <ak@....de>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Andrew Morton" <akpm@...l.org>,
	"Muli Ben-Yehuda" <muli@...ibm.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Adrian Bunk" <bunk@...sta.de>
Subject: Re: [PATCH] x86_64 irq: reuse vector for __assign_irq_vector

Andi,
please check the revised patch: It can be appied to current linus't tree.

in phys flat mode, when using set_xxx_irq_affinity to irq balance from
one cpu to another,  _assign_irq_vector will get to increase last used
vector and get new vector. this will use up the vector if enough
set_xxx_irq_affintiy are called. and end with using same vector in
different cpu for different irq. (that is not what we want, we only
want to use same vector in different cpu for different irq when more
than 0x240 irq needed). To keep it simple, the vector should be reused
instead of getting new vector.

Also according to Eric's review, make it more generic to be used with
flat mode too.

It also check if new domain and old domain is equal, to avoid extra operation.

Cc: Eric W. Biederman <ebiederm@...ssion.com>
Cc: Muli Ben-Yehuda <muli@...ibm.com>
Signed-off-by: Yinghai Lu <yinghai.lu@....com>

View attachment "io_apic_reuse_vector_1026.diff" of type "text/x-patch" (2724 bytes)