linux-kernel - Re: [PATCH 2/2] usbnet: use MII hooks only if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061028211342.GA23360@infradead.org>
Date:	Sat, 28 Oct 2006 22:13:42 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	David Brownell <david-b@...bell.net>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Randy Dunlap <randy.dunlap@...cle.com>, toralf.foerster@....de,
	netdev@...r.kernel.org, linux-usb-devel@...ts.sourceforge.net,
	link@...gy.org, greg@...ah.com, akpm@...l.org,
	zippel@...ux-m68k.org, torvalds@...l.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

On Sat, Oct 28, 2006 at 02:10:09PM -0700, David Brownell wrote:
> On Saturday 28 October 2006 4:21 am, Christoph Hellwig wrote:
> 
> > This is really awkward and against what we do in any other driver.
> 
> Awkward, yes -- which is why I posted the non-awkward version,
> which is repeated below.  (No thanks to "diff" for making the
> patch ugly though; the resulting code is clean and non-awkward,
> moving that function helped.)
> 
> Against what other drivers do?  Since "usbnet.c" is infrastructure
> code, not a driver, your comment can't apply.  Infrastructure uses
> conditional compilation routinely in such cases.
> 
> But remember that the actual drivers follow the standard convention
> ("select MII") given Randy's patch #1 of 2.

Ah sorry - I missed that.

I still don't quite like the approach.  What about simply putting
the mii using functions into usbnet-mii.c and let makefile doing
all the work?  This would require a second set of ethtool ops,
but I'd actually consider that a cleanup, as it makes clear which
one we're using and allows to kill all the checks for non-mii
hardware in the methods.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/