linux-kernel - Re: [PATCH] nfs: Fix nfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1162153188.5545.59.camel@lade.trondhjem.org>
Date:	Sun, 29 Oct 2006 15:19:48 -0500
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfs: Fix nfs_readpages() error path

On Sun, 2006-10-29 at 12:16 -0800, Andrew Morton wrote:
> On Sun, 29 Oct 2006 14:10:38 -0500
> Trond Myklebust <Trond.Myklebust@...app.com> wrote:
> 
> > Instead of the BUG_ON(), why can't we just stick a put_pages_list() into
> > __do_page_cache_readahead() and then get rid of all that duplicated
> > error handling in mpage_readpages(), nfs_readpages(), fuse_readpages(),
> > etc?
> 
> I don't recall anything which would prevent that from being done.  iirc it
> was one of those things which never happen.  Then things changed and it
> happened once and was hence a special case.  Then more things changed and
> it happened again, etc.

OK. I'll try to get round to doing it tomorrow (got to change to winter
tyres on my car today :-)).

Cheers,
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/