linux-kernel - Re: [0/3] 2.6.19-rc2: known regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0610291211160.25218@g5.osdl.org>
Date:	Sun, 29 Oct 2006 12:17:08 -0800 (PST)
From:	Linus Torvalds <torvalds@...l.org>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
cc:	Adrian Bunk <bunk@...sta.de>, Andrew Morton <akpm@...l.org>,
	Francois Romieu <romieu@...zoreil.com>,
	Jeff Garzik <jgarzik@...ox.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [0/3] 2.6.19-rc2: known regressions

On Sun, 29 Oct 2006, Guennadi Liakhovetski wrote:
> 
> I did search the archives, but it does seem to be the new one. r8169 
> network driver introduced in 2.6.19-rcX a set_mac_address function, which 
> doesn't work for me. It should resolve the bugreport 
> http://bugzilla.kernel.org/show_bug.cgi?id=6032 but, as you see from the 
> last comment from the original reporter and from my following comment, it 
> doesn't seem to. I think, it should either be fixed or reverted. My 
> test-system, was a ppc NAS (KuroboxHG):

Can you please test the things that Francois asks you to test in the last 
comment?

That said, it does appear that the patch breaks things for some people, 
and the upsides seem very limited - only relevant when somebody tries to 
change the MAC address, which is not a very normal thing to do anyway.

So maybe reverting it is the right thing to do. Guennadi, can you confirm 
that it is commit a2b98a69 ("r8169: mac address change support") that 
breaks it, and that reverting just that one commit fixes things for you?

But please check the things that are suggested in the bugzilla entry 
first.

Francois? Jeff?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/