linux-kernel - [PATCH 7/9] Char: sx, fix return in module init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <350625042580122316@karneval.cz>
Date:	Tue, 31 Oct 2006 01:42:38 +0100 (CET)
From:	Jiri Slaby <jirislaby@...il.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	<support@...cialix.co.uk>
Subject: [PATCH 7/9] Char: sx, fix return in module init

sx, fix return in module init

if pci_register_driver fails, but eisa_driver_register doesn't, we don't
call misc_deregister, but returns error. Return OK in such cases.

Signed-off-by: Jiri Slaby <jirislaby@...il.com>

---
commit c1124b32f6ab775db247b56206e3bc6f28f3f741
tree fa9a86433f5ca2c984ccd46a2c730fb9ed34feb7
parent d6a49f7c30c60781420537fea54e8133ab2ed35f
author Jiri Slaby <jirislaby@...il.com> Tue, 31 Oct 2006 00:44:54 +0100
committer Jiri Slaby <jirislaby@...il.com> Tue, 31 Oct 2006 00:44:54 +0100

 drivers/char/sx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/char/sx.c b/drivers/char/sx.c
index 4414cd8..339f278 100644
--- a/drivers/char/sx.c
+++ b/drivers/char/sx.c
@@ -2661,6 +2661,7 @@ #endif
 		retval = 0;
 	} else if (retval) {
 #ifdef CONFIG_EISA
+		retval = retval1;
 		if (retval1)
 #endif
 			misc_deregister(&sx_fw_device);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/