lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20061031071531.GT14055@kernel.dk>
Date:	Tue, 31 Oct 2006 08:15:32 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	NeilBrown <neilb@...e.de>
Cc:	Andrew Morton <akpm@...l.org>, linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] Check bio address after mapping through partitions.

On Tue, Oct 31 2006, NeilBrown wrote:
> This would be good for 2.6.19 and even 18.2, if it is seens acceptable.
> raid0 at least (possibly other) can be made to Oops with a bad partition 
> table and best fix seem to be to not let out-of-range request get down
> to the device.
> 
> ### Comments for Changeset
> 
> Partitions are not limited to live within a device.  So
> we should range check after partition mapping.
> 
> Note that 'maxsector' was being used for two different things.  I have
> split off the second usage into 'old_sector' so that maxsector can be
> still be used for it's primary usage later in the function.
> 
> Cc: Jens Axboe <jens.axboe@...cle.com>
> Signed-off-by: Neil Brown <neilb@...e.de>

Code looks good to me, but for some reason your comment exceeds 80
chars. Can you please fix that up?

Acked-by: Jens Axboe <jens.axboe@...cle.com>

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ