linux-kernel - Re: 2.6.19-rc <-> ThinkPads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4549214B.1000103@tmr.com>
Date:	Wed, 01 Nov 2006 17:35:55 -0500
From:	Bill Davidsen <davidsen@....com>
To:	Linus Torvalds <torvalds@...l.org>
CC:	Andrew Morton <akpm@...l.org>, linux-pm@...l.org,
	Ernst Herzberg <earny@...4u.de>, Andi Kleen <ak@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org, Hugh Dickins <hugh@...itas.com>,
	Adrian Bunk <bunk@...sta.de>,
	Martin Lorenz <martin@...enz.eu.org>
Subject: Re: 2.6.19-rc <-> ThinkPads

Linus Torvalds wrote:

> I wonder if the order matters more, though. Andi? We _used_ to write the 
> high word first, and I think the order matters. The low word contains the 
> enable bit, for example, so when enabling an interrupt, you should write 
> the low word last, when you disable it you should write the low word 
> first.
> 
Although you can argue that anyone coding here should be a guru, in 
practice things this subtle really would be helped by a comment in the 
initial code. I don't agree that "if it was hard to write it should be 
hard to understand." Clearly several competent people missed this 
dependency, or the patch would not have gone in.

-- 
Bill Davidsen <davidsen@....com>
   Obscure bug of 2004: BASH BUFFER OVERFLOW - if bash is being run by a
normal user and is setuid root, with the "vi" line edit mode selected,
and the character set is "big5," an off-by-one errors occurs during
wildcard (glob) expansion.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/