| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Nov 2006 23:15:07 -0800 From: Greg KH <greg@...ah.com> To: David Brownell <david-b@...bell.net> Cc: Randy Dunlap <randy.dunlap@...cle.com>, toralf.foerster@....de, netdev@...r.kernel.org, linux-usb-devel@...ts.sourceforge.net, link@...gy.org, akpm@...l.org, zippel@...ux-m68k.org, torvalds@...l.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled On Wed, Oct 25, 2006 at 07:22:08PM -0700, David Brownell wrote: > On Wednesday 25 October 2006 4:58 pm, Randy Dunlap wrote: > > On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote: > > > > > Instead, "usbnet.c" should #ifdef the relevant ethtool hooks > > > according to CONFIG_MII ... since it's completely legit to > > > use usbnet with peripherals that don't need MII. > > I had in mind something simpler -- #ifdeffing the entire functions, > as in this patch. It looks more complicated than it is, because > "diff" gets confused by moving two functions earlier in the file. > > (Thanks for starting this, Randy ... these two patches should be merged > before RC4 ships.) Argh, there were just too many different versions of these patches floating around. Can you resend the final versions please? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists