linux-kernel - Re: [PATCH 4/7] paravirtualization: Allow selected bug checks to be skipped by paravirt kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45493497.1040707@goop.org>
Date:	Wed, 01 Nov 2006 15:58:15 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Andrew Morton <akpm@...l.org>
CC:	Rusty Russell <rusty@...tcorp.com.au>,
	Chris Wright <chrisw@...s-sol.org>, Andi Kleen <ak@....de>,
	linux-kernel@...r.kernel.org, virtualization@...ts.osdl.org
Subject: Re: [PATCH 4/7] paravirtualization: Allow selected bug checks to
 be	skipped by paravirt kernels

Andrew Morton wrote:
> On Wed, 01 Nov 2006 21:30:43 +1100
> Rusty Russell <rusty@...tcorp.com.au> wrote:
>
>   
>> --- a/include/asm-i386/bugs.h
>> +++ b/include/asm-i386/bugs.h
>> @@ -21,6 +21,7 @@
>>  #include <asm/processor.h>
>>  #include <asm/i387.h>
>>  #include <asm/msr.h>
>> +#include <asm/paravirt.h>
>>     
>
> In many other places you have
>
> #ifdef CONFIG_PARAVIRT
> #include <asm/paravirt.h>
> ...
>
> But not here.
>
> Making <asm/paravirt.h> invulnerable would be the more typical approach.
CONFIG_PARAVIRT is not being used to guard asm/paravirt.h from multiple 
inclusion.  In places where it is being used to guard #include 
<asm/paravirt.h>, the idea is that asm/paravirt.h defines various 
inlines/macros which would otherwise be defined in the header.  So, for 
example, asm/desc.h would normally define load_gdt() in the 
!CONFIG_PARAVIRT case, but asm/paravirt.h defines it when 
CONFIG_PARAVIRT is enabled. 

In this case, asm/paravirt.h included because we need the definition for 
paravirt_enabled(), not because it is replacing any of bugs.h's definitions.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/