linux-kernel - Re: [PATCH 4/7] paravirtualization: Allow selected bug checks to be skipped by paravirt kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1162425710.6848.9.camel@localhost.localdomain>
Date:	Thu, 02 Nov 2006 11:01:50 +1100
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Andrew Morton <akpm@...l.org>
Cc:	Andi Kleen <ak@....de>, Andi Kleen <ak@...e.de>,
	virtualization@...ts.osdl.org, Chris Wright <chrisw@...s-sol.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7] paravirtualization: Allow selected bug checks to
	be skipped by paravirt kernels

On Wed, 2006-11-01 at 15:29 -0800, Andrew Morton wrote:
> On Wed, 01 Nov 2006 21:30:43 +1100
> Rusty Russell <rusty@...tcorp.com.au> wrote:
> 
> > --- a/include/asm-i386/bugs.h
> > +++ b/include/asm-i386/bugs.h
> > @@ -21,6 +21,7 @@
> >  #include <asm/processor.h>
> >  #include <asm/i387.h>
> >  #include <asm/msr.h>
> > +#include <asm/paravirt.h>
> 
> In many other places you have
> 
> #ifdef CONFIG_PARAVIRT
> #include <asm/paravirt.h>
> ...
> 
> But not here.
> 
> Making <asm/paravirt.h> invulnerable would be the more typical approach.

It *is* actually safe.  The "#ifdef CONFIG_PARAVIRT / #include
<asm/paravirt.h> / #else / <... native versions...>" is to give a big
hint to the reader to look in paravirt.h for the real definitions.

Originally I had a noparavirt.h where all these lived, and people hated
it.  So we did it this way, which minimizes churn.

Rusty.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/