linux-kernel - Re: [PATCH 01/02] Elf: Always define elf_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aec7e5c30611020251p7375fb39ne1f5aba8ea14a3a2@mail.gmail.com>
Date:	Thu, 2 Nov 2006 19:51:02 +0900
From:	"Magnus Damm" <magnus.damm@...il.com>
To:	"Jakub Jelinek" <jakub@...hat.com>
Cc:	"Magnus Damm" <magnus@...inux.co.jp>, linux-kernel@...r.kernel.org,
	"Vivek Goyal" <vgoyal@...ibm.com>, "Andi Kleen" <ak@....de>,
	fastboot@...ts.osdl.org, Horms <horms@...ge.net.au>,
	"Dave Anderson" <anderson@...hat.com>, ebiederm@...ssion.com
Subject: Re: [PATCH 01/02] Elf: Always define elf_addr_t in linux/elf.h

On 11/2/06, Jakub Jelinek <jakub@...hat.com> wrote:
> On Thu, Nov 02, 2006 at 07:19:42PM +0900, Magnus Damm wrote:
> > --- 0001/include/linux/elf.h
> > +++ work/include/linux/elf.h  2006-11-02 15:44:10.000000000 +0900
> > @@ -352,12 +352,16 @@ typedef struct elf64_note {
> >    Elf64_Word n_type; /* Content type */
> >  } Elf64_Nhdr;
> >
> > +typedef Elf64_Off elf64_addr;
> > +typedef Elf32_Off elf32_addr;
> > +
>
> What are these typedefs useful for?  Isn't it better just to
> use Elf32_Addr and Elf64_Addr in the #defines below?

Sure, good idea. I just added them to follow the "style" of the rest
of the file.

Thanks,

/ magnus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/