linux-kernel - Re: [KJ][PATCH] Correct misc_register return code handling in several drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061101162727.72f1183b.akpm@osdl.org>
Date:	Wed, 1 Nov 2006 16:27:27 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	"Jesper Juhl" <jesper.juhl@...il.com>,
	"Neil Horman" <nhorman@...driver.com>,
	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
	kernel-janitors@...ts.osdl.org, kjhall@...ibm.com,
	maxk@...lcomm.com, linux-kernel@...r.kernel.org
Subject: Re: [KJ][PATCH] Correct misc_register return code handling in
 several drivers

On Wed, 1 Nov 2006 16:11:55 -0800
Randy Dunlap <randy.dunlap@...cle.com> wrote:

> > Hmm, I guess that should be defined once and for all in
> > Documentation/CodingStyle
> 
> I have some other CodingStyle changes to submit, but feel free
> to write this one up.

Starting labels in column 2 gives me the creeps, personally.  But there's a
decent justification for it.

> However, I didn't know that we had a known style for this, other
> than "not indented so far that it's hidden".
> 
> If a label in column 0 [0-based :] confuses patch, then that's
> a reason, I suppose.  I wasn't aware of that one...
> In a case like that, we usually say "fix the tool then."

The problem is that `diff -p' screws up and displays the label: in the
place where it should be displaying the function name.

Of course, lots of people forget the -p anyway...  Maybe we can fix those
tools ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/