linux-kernel - Re: [RFT/PATCH] i8042: remove polling timer (v6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200611030103.17913.dtor@insightbb.com>
Date:	Fri, 3 Nov 2006 01:03:17 -0500
From:	Dmitry Torokhov <dtor@...ightbb.com>
To:	Dave Neuer <mr.fred.smoothie@...ox.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>,
	Vojtech Pavlik <vojtech@...e.cz>
Subject: Re: [RFT/PATCH] i8042: remove polling timer (v6)

On Sunday 29 October 2006 18:20, Dave Neuer wrote:
> On 8/23/06, Dmitry Torokhov <dtor@...ightbb.com> wrote:
> > Hi everyone,
> >
> > Here is another version of the patch removing polling timer from i8042
> > which is needed if we want tickless kernel. Keyboards should now work
> > on boxes that do not have mouse plugged in. PLease give it a test.
> 
>  What's the intent of this; just to allow tickless?

Yes, that was the intent.

>  Or is it also to 
> make the i8042 driver less racy? 

I think we agree that i8042_aux_write() is not racy, do you see any other
races in i8042?

> I ask because I've applied this over 
> (a modified) 2.6.18 on my Compaq Presario X1010us laptop which has
> been driving me crazy w/ Synaptics problems and keyboard problems
> (intermittent, but   frequent enough lately that I finally figured I
> needed to do something about it).
> 

Have you tried limiting Synaptics rate to 40 packets per second (using
psmouse.rate=40 option)? Some KBD can't handle full Synaptics rate of
80 pps; it usually manifests in keyboard troubles.

> 
> I don't really know if or how much the races in this driver are
> contributing to my problems (keyboard getting stuck repeating last
> key, or ignoring interrupts, or synaptics touchpad freezing, last of
> which requires cold boot to fix).

You mean even reloading psmouse module can't revive the touchpad?

> Maybe more likely an ACPI thing? 

Coudl be.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/