linux-kernel - Re: [PATCH] airo.c: check returned values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <454F470C.2050407@gmail.com>
Date:	Mon, 06 Nov 2006 09:30:36 -0500
From:	Florin Malita <fmalita@...il.com>
To:	Jeff Garzik <jgarzik@...ox.com>
CC:	akpm@...l.org, linville@...driver.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] airo.c: check returned values

Jeff Garzik wrote:
> Florin Malita wrote:
>   
>> create_proc_entry() can fail and return NULL in setup_proc_entry(), the
>> result must be checked before dereferencing. (Coverity ID 1443)
>>
>> init_wifidev() & setup_proc_entry() can also fail in _init_airo_card().
>>
>> This adds the checks & cleanup code and removes some whitespace.
>>
>> Signed-off-by: Florin Malita <fmalita@...il.com>
>>     
>
> NAK:  create_proc_entry() is complicated.  You are correct it can fail 
> -- but to add to the confusion, when CONFIG_PROC_FS is disabled, the 
> wrapper will also return NULL -- which is NOT a failure case.
>   

It is a failure condition for setup_proc_entry() but you're saying that
shouldn't cause a failure of _init_airo_card() as the driver would be
working fine even without procfs support, right?

Note that previously the no-procfs case was *really* broken (it would
explode right away in setup_proc_entry) and I'm not sure it can function
correctly without it now but I guess it's worth a try.

Which one would be preferred:

 a) make the setup_proc_entry() call in _init_airo_card() conditional on
CONFIG_PROC_FS
 b) simply ignore the result

---
fm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/