linux-kernel - Re: [PATCH] airo.c: check returned values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <454EEAEB.5030606@pobox.com>
Date:	Mon, 06 Nov 2006 02:57:31 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Florin Malita <fmalita@...il.com>
CC:	akpm@...l.org, linville@...driver.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] airo.c: check returned values

Florin Malita wrote:
> create_proc_entry() can fail and return NULL in setup_proc_entry(), the
> result must be checked before dereferencing. (Coverity ID 1443)
> 
> init_wifidev() & setup_proc_entry() can also fail in _init_airo_card().
> 
> This adds the checks & cleanup code and removes some whitespace.
> 
> Signed-off-by: Florin Malita <fmalita@...il.com>

NAK:  create_proc_entry() is complicated.  You are correct it can fail 
-- but to add to the confusion, when CONFIG_PROC_FS is disabled, the 
wrapper will also return NULL -- which is NOT a failure case.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/