linux-kernel - Re: + net-uninline-xfrm_selector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061106144932.8c63a6ed.akpm@osdl.org>
Date:	Mon, 6 Nov 2006 14:49:32 -0800
From:	Andrew Morton <akpm@...l.org>
To:	David Miller <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org, acme@...driva.com
Subject: Re: + net-uninline-xfrm_selector_match.patch added to -mm tree

On Mon, 06 Nov 2006 14:38:31 -0800 (PST)
David Miller <davem@...emloft.net> wrote:

> From: akpm@...l.org
> Date: Fri, 03 Nov 2006 11:34:12 -0800
> 
> > Subject: net: uninline xfrm_selector_match()
> > From: Andrew Morton <akpm@...l.org>
> > 
> > Six callsites, huge.
> > 
> > Cc: Arnaldo Carvalho de Melo <acme@...driva.com>
> > Signed-off-by: Andrew Morton <akpm@...l.org>
> 
> You can't implement it like this :-)
> 
> xfrm_user.c is a bad place to put the uninlined version because
> this can be built modular, whereas the callsites in places such
> as xfrm_policy.c will be built statically into the kernel.

I would have found that out when I got around to compiling it ;)

Where should the out-of-line function be placed, or should I just drop it? 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/