linux-kernel - Re: [PATCH] input: map BTN_FORWARD to button 2 in mousedev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 Nov 2006 09:15:43 +0100 (CET)
From:	Németh Márton <nm127@...email.hu>
To:	Dmitry Torokhov <dtor@...ightbb.com>
cc:	linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: map BTN_FORWARD to button 2 in mousedev

Dmitry Torokhov <dtor@...ightbb.com> wrote:

> On 11/5/06, Németh Márton <nm127@...email.hu> wrote:
> > From: Márton Németh <nm127@...email.hu>
> >
> > In mousedev the BTN_LEFT and BTN_FORWARD were mapped to
mouse button 0, causing
> > that the user space program cannot distinguish between
them through /dev/input/mice.
> > The BTN_FORWARD is currently used in the synaptics.c,
logips2pp.c and in alps.c. All
> > mice have BTN_LEFT, but not all have BTN_MIDDLE (e.g.
Clevo D410J laptop). Mapping
> > BTN_FORWARD to mouse button 2 makes the BTN_FORWARD
button useful on the mentioned
> > laptop.
> >
> 
> I'd rather not touch mappings in legacy mousedev driver. I
believe
> both synaptics and evdev X drivers will correctly recognize
> BTN_FORWARD, is there any reason you are not using them?

If I have understand the input subsystem correctly, for the
evdev X driver the mousedev.c is not needed, so using an
evdev X driver is a completely other story. This map change
could result that the BTN_FORWARD can be used as BTN_MIDDLE
out of the box, without any additional drivers, so it is
simpler (at least in case of Clevo D410J).

My patch is based on the assumption that every mouse has
BTN_LEFT, so it is not worth having two mouse buttons for
the same function. (For Clevo D410J it is actually an
information loss at this point.)

Next thing is that the BTN_FORWARD and BTN_BACK usually
comes together. The BTN_LEFT and BTN_RIGHT usually comes
together also. For the mapping I see some possible mapping
listed in the following table:

    Button name    |     (a)     |     (b)     |     (c)     |
    ---------------+-------------+-------------+-------------+
    BTN_LEFT       |      0      |      0      |      0      |
    BTN_RIGHT      |      1      |      1      |      1      |
    BTN_FORWARD    |      0      |      2      |      0      |
    BTN_BACK       |      1      |      3      |      3      |

Mapping (a) would map BTN_FORWARD and BTN_BACK to BTN_LEFT
and BTN_RIGHT. Mapping (b) would map all 4 buttons to
different buttons. Mapping (c) is the current mapping where
the BTN_FORWARD is handled differently than BTN_BACK.

        NMarci

___________________________________________________________________________
Karácsonyi sorban állás helyett vásároljon kényelmesen! Garantáltan 1 nap alatt szállítjuk a megrendelt könyveket!
http://www.bookline.hu/control/news?newsid=528&affiliate=frenapkar3171

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/