linux-kernel - Re: [PATCH 0/1] mspec driver: compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4550609A.7010908@sgi.com>
Date:	Tue, 07 Nov 2006 11:31:54 +0100
From:	Jes Sorensen <jes@....com>
To:	Fernando Luis Vázquez Cao 
	<fernando@....ntt.co.jp>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	bjorn_helgaas@...com, Nick Piggin <nickpiggin@...oo.com.au>,
	Andrew Morton <akpm@...l.org>, Robin Holt <holt@....com>,
	Dean Nelson <dcn@....com>, Hugh Dickins <hugh@...itas.com>,
	Linus Torvalds <torvalds@...l.org>,
	linux-ia64 <linux-ia64@...r.kernel.org>,
	Tony Luck <tony.luck@...il.com>
Subject: Re: [PATCH 0/1] mspec driver: compile error

Fernando Luis Vázquez Cao wrote:
> Hi Jes,
> 
> After selecting CONFIG_MSPEC as a module I stumbled onto the compile
> error below.
[snip]
> I'll be replying to this message with a patch that implements this. I
> would appreciate your review and comments.

Hi Fernando,

As I also mentioned in my reply to Peter Chubb, this is the wrong fix
for this problem as the driver should operate in cached and uncached
mode on non SN2 systems.

Here is the correct fix. I have test it on SN2 and made sure it builds
for DIG, but I can't easily test it. However I see no reason why it
should cause problems.

This is ending up as an attachment since it ended up in the IMAP only
mailbox. Somehow I am willing to bet Thunderbug will do something stupid
to it, like base64 encode it.

Cheers,
Jes

PS: When you post fixes for an IA64 specific driver like this, please
    always remember to CC the ia64 list and the ia64 maintainer on it!

View attachment "mspec-dig-build.diff" of type "text/plain" (2600 bytes)