linux-kernel - [PATCH 0/1] mspec driver: compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 07 Nov 2006 15:30:17 +0900
From:	Fernando Luis Vázquez Cao 
	<fernando@....ntt.co.jp>
To:	jes@....com
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	bjorn_helgaas@...com, Nick Piggin <nickpiggin@...oo.com.au>,
	Andrew Morton <akpm@...l.org>, Robin Holt <holt@....com>,
	Dean Nelson <dcn@....com>, Hugh Dickins <hugh@...itas.com>,
	Linus Torvalds <torvalds@...l.org>
Subject: [PATCH 0/1] mspec driver: compile error

Hi Jes,

After selecting CONFIG_MSPEC as a module I stumbled onto the compile
error below.

WARNING: "bte_copy" [drivers/char/mspec.ko] undefined!
WARNING: "physical_node_map" [drivers/char/mspec.ko] undefined!
WARNING: "uncached_free_page" [drivers/char/mspec.ko] undefined!
WARNING: "per_cpu____sn_hub_info" [drivers/char/mspec.ko] undefined!
WARNING: "uncached_alloc_page" [drivers/char/mspec.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

The problem is that the Kconfig dependencies for MSPEC are a bit too
loose. The mspec driver needs bte_copy (a sn-specific function) as well
as some functions of the uncached page allocator.

I solved the issue by making the dependencies explicit in
drivers/char/Kconfig:
--- Current Kconfig entry
config MSPEC
	tristate "Memory special operations driver"
	depends on IA64
	help
	  If you have an ia64 and you want to enable memory special
	  operations support (formerly known as fetchop), say Y here,
	  otherwise say N.
---
--- Proposed Kconfig entry
config MSPEC
        tristate "Memory special operations driver"
        depends on IA64 && (IA64_GENERIC || IA64_SGI_SN2)
        select IA64_UNCACHED_ALLOCATOR
        help
          If you have an ia64 and you want to enable memory special
          operations support (formerly known as fetchop), say Y here,
          otherwise say N.
---

I'll be replying to this message with a patch that implements this. I
would appreciate your review and comments.

Regards,

Fernando

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/