[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1162963585.22062.173.camel@amol.verismonetworks.com>
Date: Wed, 08 Nov 2006 10:56:25 +0530
From: Amol Lad <amol@...ismonetworks.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: Andrew Morton <akpm@...l.org>, James.Bottomley@...eleye.com,
linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/scsi/mca_53c9x.c : save_flags()/cli() removal
On Tue, 2006-11-07 at 22:29 +0000, Christoph Hellwig wrote:
> On Mon, Nov 06, 2006 at 06:12:11PM +0530, Amol Lad wrote:
> > Replaced save_flags()/cli() with spin_lock alternatives
>
> This patch has very little chance to work as-is because it only replaces
> cli with spinlocks, but not the irq handler it's locking against.
>
It protects against irq handler also.
drivers/scsi/NCR53C9x.c:
irqreturn_t esp_intr(int irq, void *dev_id)
{
struct NCR_ESP *esp;
unsigned long flags;
int again;
struct Scsi_Host *dev = dev_id;
/* Handle all ESP interrupts showing at this IRQ level. */
spin_lock_irqsave(dev->host_lock, flags);
...
...
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists