linux-kernel - Re: [PATCH] drivers/scsi/mca_53c9x.c : save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Nov 2006 11:06:41 +0530
From:	Amol Lad <amol@...ismonetworks.com>
To:	James Bottomley <James.Bottomley@...elEye.com>
Cc:	Andrew Morton <akpm@...l.org>,
	linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/scsi/mca_53c9x.c : save_flags()/cli() removal

On Wed, 2006-11-08 at 09:19 +0900, James Bottomley wrote:
> On Tue, 2006-11-07 at 12:53 -0800, Andrew Morton wrote:
> 
> > hm.  How do we find out if this works?
> 
> I'm not sure anyone has this type of HW anymore.  It was the original
> SCSI chip for the old MCA based IBM PC.  I can dig through my hardware
> bins to see if I have a card, but I don't think so.

The only way I see is the code review. 

Most of the drivers using save_flags()/cli() interfaces are not in use
anymore (such as drivers/char/riscom8.c). There are two possibilities:
1. Remove such drivers from kernel
2. Fix them

This would mean we can remove cli()/sti()/save_flags() interfaces from
the kernel so that any new development does not uses them accidently

> 
> > If it _does_ work then we can now remove the Kconfig BROKEN_ON_SMP dependency
> > for this driver.
> 
> Theoretically, yes ... practically I don't think there was an SMP box
> produced with this chip.
> 
> James
> 
> 
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/