lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1163099886.29807.20.camel@dyn9047017100.beaverton.ibm.com>
Date:	Thu, 09 Nov 2006 11:18:06 -0800
From:	Badari Pulavarty <pbadari@...ibm.com>
To:	Sébastien Dugué <sebastien.dugue@...l.net>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Suparna Bhattacharya <suparna@...ibm.com>,
	Ulrich Drepper <drepper@...hat.com>,
	Zach Brown <zach.brown@...cle.com>,
	Dave Jones <davej@...hat.com>,
	Jean Pierre Dion <jean-pierre.dion@...l.net>,
	"linux-aio@...ck.org" <linux-aio@...ck.org>
Subject: Re: [PATCH -mm 3/3][AIO] - AIO completion signal notification

On Thu, 2006-11-09 at 16:59 +0100, Sébastien Dugué wrote:

> @@ -1549,8 +1657,7 @@ int fastcall io_submit_one(struct kioctx
>  	ssize_t ret;
>  
>  	/* enforce forwards compatibility on users */
> -	if (unlikely(iocb->aio_reserved1 || iocb->aio_reserved2 ||
> -		     iocb->aio_reserved3)) {
> +	if (unlikely(iocb->aio_reserved1)) {
>  		pr_debug("EINVAL: io_submit: reserve field set\n");
>  		return -EINVAL;

Is there a reason for not checking "aio_reserved3" ?
You are still not using it. Right ?

Thanks,
Badari

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ