linux-kernel - Re: [PATCH 02/02] Elf: Align elf notes properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aec7e5c30611121816s2087c455o6dea419d13de5615@mail.gmail.com>
Date:	Mon, 13 Nov 2006 11:16:19 +0900
From:	"Magnus Damm" <magnus.damm@...il.com>
To:	"Jeremy Fitzhardinge" <jeremy@...p.org>
Cc:	"David Miller" <davem@...emloft.net>, horms@...ge.net.au,
	ebiederm@...ssion.com, magnus@...inux.co.jp,
	linux-kernel@...r.kernel.org, vgoyal@...ibm.com, ak@....de,
	fastboot@...ts.osdl.org, anderson@...hat.com
Subject: Re: [PATCH 02/02] Elf: Align elf notes properly

On 11/11/06, Jeremy Fitzhardinge <jeremy@...p.org> wrote:
> David Miller wrote:
> > We should be OK with the elf note header since n_namesz, n_descsz, and
> > n_type are 32-bit types even on Elf64.  But for the contents embedded
> > in the note, I am not convinced that there are no potential issues
>
> PT_NOTE segments are not generally mmaped directly, nor are they
> generally very large.  There should be no problem for a note-using
> program to load/copy the notes into memory with appropriate alignment.
> I guess a lot of the contents of core elf notes are register dumps and
> so on, so debuggers must be already dealing with this.

Someone apparently thought that 32-bit alignment was a good thing and
put it in the spec for the 32-bit format. You argue that most programs
copy instead of mmap() which sounds correct, but if someone wants to
mmap() then our current 32-bit aligned 64-bit elf note implementation
is broken. Which may or may not be ok.

So why was 32-bit alignment put in the 32-bit spec? I suspect the
reason was to support direct access of note contents. Either using
mmap() or read() and direct access. Remeber that the notes could
contain anything which may require properly aligned data for direct
access. I think this was the reason the word size alignment was put in
the spec for in the first place.

Thanks,

/ magnus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/