linux-kernel - Re: [PATCH 02/02] Elf: Align elf notes properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061112.174749.30185202.davem@davemloft.net>
Date:	Sun, 12 Nov 2006 17:47:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	horms@...ge.net.au
Cc:	jeremy@...p.org, magnus.damm@...il.com, ebiederm@...ssion.com,
	magnus@...inux.co.jp, linux-kernel@...r.kernel.org,
	vgoyal@...ibm.com, ak@....de, fastboot@...ts.osdl.org,
	anderson@...hat.com
Subject: Re: [PATCH 02/02] Elf: Align elf notes properly

From: Horms <horms@...ge.net.au>
Date: Mon, 13 Nov 2006 09:23:03 +0900

> On Fri, Nov 10, 2006 at 04:43:49PM -0800, David Miller wrote:
> > From: Jeremy Fitzhardinge <jeremy@...p.org>
> > Date: Fri, 10 Nov 2006 16:26:46 -0800
> > 
> > > David Miller wrote:
> > > > I think Elf64 notes very much would need 64-bit alignment, especially
> > > > if there are u64 objects in there.  Otherwise it would not be possible
> > > > to directly dereference such objects without taking unaligned faults
> > > > on several types of RISC cpus.
> > > >   
> > > 
> > > That doesn't appear to have been a problem.
> > 
> > We should be OK with the elf note header since n_namesz, n_descsz, and
> > n_type are 32-bit types even on Elf64.  But for the contents embedded
> > in the note, I am not convinced that there are no potential issues.
> 
> The interesting thing is that from my reading of the elf64 spec,
> name ends up being 32 bit alightned, and desc ends up being 64 bit
> aligned. Do you think the former could be a problem? I am thinking not
> as its always a string.

Right, it should be fine.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/