linux-kernel - Re: [PATCH] autofs4 - panic after mount fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1163433304.3016.30.camel@localhost>
Date:	Mon, 13 Nov 2006 23:55:04 +0800
From:	Ian Kent <raven@...maw.net>
To:	David Howells <dhowells@...hat.com>
Cc:	Andrew Morton <akpm@...l.org>, "bibo,mao" <bibo.mao@...el.com>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] autofs4 - panic after mount fail

On Mon, 2006-11-13 at 23:51 +0800, Ian Kent wrote:
> On Mon, 2006-11-13 at 11:07 +0000, David Howells wrote:
> > Ian Kent <raven@...maw.net> wrote:
> > 
> > > -	if (sbi->pipe) {
> > > -		fput(sbi->pipe);	/* Close the pipe */
> > > -		sbi->pipe = NULL;
> > > -	}
> > > +	fput(sbi->pipe);	/* Close the pipe */
> > > +	sbi->pipe = NULL;
> > 
> > Ummm...  Is that right?  fput() doesn't check its argument for a NULL pointer,
> > so the original code shouldn't hurt and should give you an extra bit of
> > defense.
> 
> HaHa .. sometimes it's people saying "get id of that you don't need it"
> and other times it's the opposite.
> 
> Setting sbi->catatonic = 1 upon entry to autofs[4]_fill_super ensures
> that autofs[4]_catatonic_mode is not called until after sbi->pipe is non
> NULL. So I decided, in this case, to remove the test.

However, if you feel strongly about it I'll change it.

Ian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/