linux-kernel - Re: [PATCH] Apple Motion Sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1163450519.23807.11.camel@localhost.localdomain>
Date:	Mon, 13 Nov 2006 21:41:59 +0100
From:	Stelian Pop <stelian@...ies.net>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Andrew Morton <akpm@...l.org>,
	Dmitry Torokhov <dtor_core@...ritech.net>,
	Michael Hanselmann <linux-kernel@...smi.ch>,
	"Aristeu S. Rozanski F." <aris@...hedrallabs.org>,
	Johannes Berg <johannes@...solutions.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Robert Love <rml@...ell.com>,
	Rene Nussbaumer <linux-kernel@...lerfox.forkbomb.ch>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Apple Motion Sensor driver

Le lundi 13 novembre 2006 à 19:06 +0100, Jean Delvare a écrit :
> Hi Stelian,
> 
> On Sat, 11 Nov 2006 22:36:11 +0100, Stelian Pop wrote:
> > This driver adds support for the Apple Motion Sensor (AMS) as found in 2005
> > revisions of Apple PowerBooks and iBooks.  It implements both the PMU and
> > I²C variants.  The I²C driver and mouse emulation is based on code by
> > Stelian Pop <stelian@...ies.net>, while the PMU driver has been developped
> > by Michael Hanselmann <linux-kernel@...smi.ch>. HD parking support will be
> > added later.
> > 
> > Various people contributed fixes to this driver, including
> > Aristeu Sergio Rozanski Filho <aris@...hedrallabs.org> and
> > Jean Delvare <khali@...ux-fr.org>.
> > 
> > This patch lived for a while in the -mm tree but was dropped by Andrew in
> > 2.6.18-mm1 because of some conflicting changes he was send at the time.
> > Things have settled down since then, I merged all the bits and pieces and 
> > rediffed against the latest git.
> > 
> > This driver should be quite mature to go directly into the input tree. If not,
> > Andrew please pick it up again.
> > 
> > (...)
> >  b/drivers/hwmon/ams/Makefile    |    8 +
> >  b/drivers/hwmon/ams/ams-core.c  |  265 +++++++++++++++++++++++++++++++++++
> >  b/drivers/hwmon/ams/ams-i2c.c   |  299 ++++++++++++++++++++++++++++++++++++++++
> >  b/drivers/hwmon/ams/ams-mouse.c |  147 +++++++++++++++++++
> >  b/drivers/hwmon/ams/ams-pmu.c   |  207 +++++++++++++++++++++++++++
> >  b/drivers/hwmon/ams/ams.h       |   72 +++++++++
> >  drivers/hwmon/Kconfig           |   25 +++
> >  drivers/hwmon/Makefile          |    1 
> >  8 files changed, 1024 insertions(+)
> 
> There's some confusion here. On the one hand, you placed your driver
> in the hwmon directory, and integrated it in the Hardware Monitoring
> menu. But on the other hand you seem to think that the input tree is
> the natural merge path for this patch. Isn't it strange?

This is because I got myself confused when writing that sentence
(minutes ago I was sending a patch for the appletouch driver, targeted
at the input tree).

I do believe that the proper place for ams is the hardware monitoring
section (even if the missing HD parking APIs makes it not very useful
right now).

The fact that the accelerometer offers a (low res) joystick emulation is
only a nice hack and I'm not even sure somebody (except Johannes) will
find an use for it.

-- 
Stelian Pop <stelian@...ies.net>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/