linux-kernel - [PATCH] atkbd: disable spurious ACK/NAK warning on panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Nov 2006 21:43:40 +0100
From:	Luca Tettamanti <kronos.it@...il.com>
To:	Vojtech Pavlik <vojtech@...e.cz>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] atkbd: disable spurious ACK/NAK warning on panic

After the panic() message has been printed kernel may blink keyboard
leds to signal the abnormal condition.
atkbd warns that "Some program might be trying access hardware directly"
at every blink, scrolling the useful text out of the screen.
Avoid printing the warning when oops_in_progress is set in order to
preserve the panic message.

Signed-Off-By: Luca Tettamanti <kronos.it@...il.com>

---
 Patch against current GIT tree.

 drivers/input/keyboard/atkbd.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index cbb9366..81d2701 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -412,6 +412,8 @@ static irqreturn_t atkbd_interrupt(struc
 			goto out;
 		case ATKBD_RET_ACK:
 		case ATKBD_RET_NAK:
+			if (oops_in_progress)
+				goto out;
 			printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
 			       "Some program might be trying access hardware directly.\n",
 			       data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);


Luca
-- 
"In linea di principio sarei indifferente al natale, se solo il natale
 ricambiasse la cortesia e mi lasciasse in pace." -- Marco d'Itri
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/